Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10435 )
Change subject: KUDU-2427: retry more system calls on EINTR ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/10435/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10435/5//COMMIT_MSG@9 PS5, Line 9: In order to collect our own stack traces, we send ourselves a SIGUSR2. The > It's worth noting that for the SIGUSR2 case we set SA_RESTART on our signal Good question. According to signal(7), not all syscalls are restarted. There's a length list of system calls that will not be restarted, and the restartability of some I/O-related syscalls depends on the properties of the file backing the fd. In my testing I observed fallocate(2) returning EINTR, which isn't documented in that list. -- To view, visit http://gerrit.cloudera.org:8080/10435 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6cce03c4e1b2be32c1910382737526082fc99966 Gerrit-Change-Number: 10435 Gerrit-PatchSet: 5 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 18 May 2018 03:08:52 +0000 Gerrit-HasComments: Yes
