Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10612 )
Change subject: [rebalancer] 'auto' mode for RF=1 tablet movements ...................................................................... Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/10612/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10612/3//COMMIT_MSG@10 PS3, Line 10: nit: Fixed two spaces. http://gerrit.cloudera.org:8080/#/c/10612/3//COMMIT_MSG@10 PS3, Line 10: based on : the version Added guide to behavior per version to the commit msg. http://gerrit.cloudera.org:8080/#/c/10612/3//COMMIT_MSG@12 PS3, Line 12: nit: Added "the". http://gerrit.cloudera.org:8080/#/c/10612/3/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/10612/3/src/kudu/tools/kudu-admin-test.cc@1464 PS3, Line 1464: "--move_single_replicas=enabled" This isn't necessary with this patch, and serves as a light test that the version detection is working. http://gerrit.cloudera.org:8080/#/c/10612/3/src/kudu/tools/tool_action_cluster.cc File src/kudu/tools/tool_action_cluster.cc: http://gerrit.cloudera.org:8080/#/c/10612/3/src/kudu/tools/tool_action_cluster.cc@116 PS3, Line 116: if (std::find(allowed_values.begin(), allowed_values.end(), flag_value) != : allowed_values.end()) { : return true; : } Adjusted to be case-insensitive. http://gerrit.cloudera.org:8080/#/c/10612/3/src/kudu/tools/tool_action_cluster.cc@152 PS3, Line 152: ksck_result nit: ksck_results http://gerrit.cloudera.org:8080/#/c/10612/3/src/kudu/tools/tool_action_cluster.cc@235 PS3, Line 235: auto ver_str_all_good = true; : string ver_str_offending; This version stuff will be pulled into a different patch and put in a different file. While it will hopefully be rare, this should give us a sane way to manage enabling or disabling capabilities of tools based on the versions in the cluster the tool is operating on. -- To view, visit http://gerrit.cloudera.org:8080/10612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id5a06b137cb34d9351f7e2fb819ed52790e2ee7e Gerrit-Change-Number: 10612 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 12 Jun 2018 17:40:30 +0000 Gerrit-HasComments: Yes
