Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10612 )
Change subject: [rebalancer] 'auto' mode for RF=1 tablet movements ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/10612/7/src/kudu/tools/tool_action_cluster.cc File src/kudu/tools/tool_action_cluster.cc: http://gerrit.cloudera.org:8080/#/c/10612/7/src/kudu/tools/tool_action_cluster.cc@226 PS7, Line 226: > Indeed -- it should return false if it's 3-2-3. It seems like a typo. Was there a test to cover this? Seems like there should have been; otherwise the existing code may have been merged. http://gerrit.cloudera.org:8080/#/c/10612/8/src/kudu/tools/tool_action_cluster.cc File src/kudu/tools/tool_action_cluster.cc: http://gerrit.cloudera.org:8080/#/c/10612/8/src/kudu/tools/tool_action_cluster.cc@244 PS8, Line 244: take long time Nit: take a long time http://gerrit.cloudera.org:8080/#/c/10612/8/src/kudu/tools/tool_action_cluster.cc@246 PS8, Line 246: available Nit: be available -- To view, visit http://gerrit.cloudera.org:8080/10612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id5a06b137cb34d9351f7e2fb819ed52790e2ee7e Gerrit-Change-Number: 10612 Gerrit-PatchSet: 8 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Sat, 23 Jun 2018 16:36:43 +0000 Gerrit-HasComments: Yes
