Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10990 )
Change subject: memrowset: support iteration with is_deleted virtual column ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/10990/2/src/kudu/tablet/memrowset-test.cc File src/kudu/tablet/memrowset-test.cc: http://gerrit.cloudera.org:8080/#/c/10990/2/src/kudu/tablet/memrowset-test.cc@592 PS2, Line 592: Cartesian product The case where we have omit_deleted_rows = true and add_vc_is_deleted = true seems confusing. Maybe at the higher levels we should prohibit it? http://gerrit.cloudera.org:8080/#/c/10990/2/src/kudu/tablet/memrowset-test.cc@622 PS2, Line 622: omit how about include instead of omit to avoid setting a parameter to true for a negative? http://gerrit.cloudera.org:8080/#/c/10990/2/src/kudu/tablet/memrowset-test.cc@632 PS2, Line 632: false /* is_key */ nit: /* is_key= */ false will get clang-tidy support http://gerrit.cloudera.org:8080/#/c/10990/2/src/kudu/tablet/memrowset.cc File src/kudu/tablet/memrowset.cc: http://gerrit.cloudera.org:8080/#/c/10990/2/src/kudu/tablet/memrowset.cc@562 PS2, Line 562: reinterpret_cast<bool*> Is there no type safe way to set this cell value? -- To view, visit http://gerrit.cloudera.org:8080/10990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6b053f5a3696eb9d7c26b8e3d96752f4f87bcd8 Gerrit-Change-Number: 10990 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 19 Jul 2018 19:11:59 +0000 Gerrit-HasComments: Yes
