Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10990 )
Change subject: memrowset: support iteration with is_deleted virtual column ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/10990/2/src/kudu/tablet/memrowset-test.cc File src/kudu/tablet/memrowset-test.cc: http://gerrit.cloudera.org:8080/#/c/10990/2/src/kudu/tablet/memrowset-test.cc@592 PS2, Line 592: Cartesian product > Right, there's no use case for omit_deleted_rows && add_vc_is_deleted, just ok, sounds good http://gerrit.cloudera.org:8080/#/c/10990/2/src/kudu/tablet/memrowset.cc File src/kudu/tablet/memrowset.cc: http://gerrit.cloudera.org:8080/#/c/10990/2/src/kudu/tablet/memrowset.cc@562 PS2, Line 562: reinterpret_cast<bool*> > Heh, I was hoping you or Todd would point me at a better way. I don't know offhand (maybe Todd does) but there must be a way. -- To view, visit http://gerrit.cloudera.org:8080/10990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6b053f5a3696eb9d7c26b8e3d96752f4f87bcd8 Gerrit-Change-Number: 10990 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 19 Jul 2018 22:31:30 +0000 Gerrit-HasComments: Yes
