Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11084 )
Change subject: perf loadgen: add --auto_database flag and change auto table name generation ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11084/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/11084/1/src/kudu/tools/kudu-tool-test.cc@1504 PS1, Line 1504: > It's what my editor did automatically, it's two spaces per open paren. Do Well, I'm not sure about standard, but I thought it would be either 4 spaces (i.e. twice the embedded scope shift) or aligned with the opening corresponding opening parenthesis. But it's just a nit, though. -- To view, visit http://gerrit.cloudera.org:8080/11084 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20654f7c1525f3804c5f307d90d23e43b3882e8a Gerrit-Change-Number: 11084 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 30 Jul 2018 23:27:16 +0000 Gerrit-HasComments: Yes
