Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11084 )
Change subject: perf loadgen: add --auto_database flag and change auto table name generation ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11084/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11084/2//COMMIT_MSG@10 PS2, Line 10: A new flag allows the database to : be configured, and defaults to the 'default' HMS database. > This sort-of kind-of exposes the idea of a database beyond just the confine In a few cases I've modified tests to use an HMS-compatible name even though the test only runs with HMS integration enabled via a parameter. This is the first and only non-test code to my knowledge. That follows pretty directly from this being the only non-test code which creates tables. If we wanted to be really fancy we could auto-detect whether the HMS is enabled through the GetFlags API and do something special, but in my opinion it's better to change the behavior now and make it consistent going forward. -- To view, visit http://gerrit.cloudera.org:8080/11084 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20654f7c1525f3804c5f307d90d23e43b3882e8a Gerrit-Change-Number: 11084 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 31 Jul 2018 00:09:43 +0000 Gerrit-HasComments: Yes
