Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11084 )
Change subject: perf loadgen: add --auto_database flag and change auto table name generation ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/11084/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11084/2//COMMIT_MSG@10 PS2, Line 10: A new flag allows the database to : be configured, and defaults to the 'default' HMS database. > I don't think being coy will help, but I've added a sentence about being us Do you think we should default it to empty string, since hms integration is not enabled by default? http://gerrit.cloudera.org:8080/#/c/11084/5/src/kudu/tools/tool_action_perf.cc File src/kudu/tools/tool_action_perf.cc: http://gerrit.cloudera.org:8080/#/c/11084/5/src/kudu/tools/tool_action_perf.cc@294 PS5, Line 294: a table is " : "not created nit: 'existing table is used' to be more clear? -- To view, visit http://gerrit.cloudera.org:8080/11084 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20654f7c1525f3804c5f307d90d23e43b3882e8a Gerrit-Change-Number: 11084 Gerrit-PatchSet: 6 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 31 Jul 2018 19:08:12 +0000 Gerrit-HasComments: Yes
