Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11036 )
Change subject: hms tools: do not require HMS configuration flags ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/11036/12/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/11036/12/src/kudu/tools/tool_action_hms.cc@135 PS12, Line 135: CHECK(hms_sasl_enabled != flags.end()); > Just curious: why it's not an option to have DCHECK() instead of CHECK() he ah so the latest revision introduced a bug here that I didn't realize till you pointed this section out. The original reason was that we were retrieving all the flags from the master, and if the hive_metastore_uris flag exists on the master then the hive_metastore_sasl_enabled flag must also, however now we're only retrieving non-default flags, so we should just assum false if it's not in the list. http://gerrit.cloudera.org:8080/#/c/11036/12/src/kudu/tools/tool_action_hms.cc@692 PS12, Line 692: .AddOptionalParameter("hive_metastore_sasl_enabled", boost::none, kHmsSaslEnabledDesc) : .AddOptionalParameter("hive_metastore_uris", boost::none, kHmsUrisDesc) > It might be mentioned elsewhere, but it seems I missed that and could not f Woops, they should be present for check as well. -- To view, visit http://gerrit.cloudera.org:8080/11036 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf580384a1612174a75142295d7f604cd6fabfe1 Gerrit-Change-Number: 11036 Gerrit-PatchSet: 12 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 01 Aug 2018 01:13:03 +0000 Gerrit-HasComments: Yes
