Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11036 )

Change subject: hms tools: do not require HMS configuration flags
......................................................................


Patch Set 13: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11036/12/src/kudu/tools/tool_action_hms.cc
File src/kudu/tools/tool_action_hms.cc:

http://gerrit.cloudera.org:8080/#/c/11036/12/src/kudu/tools/tool_action_hms.cc@135
PS12, Line 135: // SetCommandLineOption avoids needing
> ah so the latest revision introduced a bug here that I didn't realize till
Ah, indeed.  Good catch!



--
To view, visit http://gerrit.cloudera.org:8080/11036
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf580384a1612174a75142295d7f604cd6fabfe1
Gerrit-Change-Number: 11036
Gerrit-PatchSet: 13
Gerrit-Owner: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Hao Hao <hao....@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 01 Aug 2018 02:16:12 +0000
Gerrit-HasComments: Yes

Reply via email to