Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10990 )
Change subject: memrowset: support iteration with is_deleted virtual column ...................................................................... Patch Set 9: (1 comment) > Patch Set 9: > > (1 comment) http://gerrit.cloudera.org:8080/#/c/10990/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10990/9//COMMIT_MSG@15 PS9, Line 15: We could require one or the other, but that : pokes a hole in the abstraction of a virtual column as just a data type, : which seems undesirable. FWIW I think this would be fine, the non-nullable PK restrictions are kind of similar. -- To view, visit http://gerrit.cloudera.org:8080/10990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6b053f5a3696eb9d7c26b8e3d96752f4f87bcd8 Gerrit-Change-Number: 10990 Gerrit-PatchSet: 9 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 03 Aug 2018 00:06:02 +0000 Gerrit-HasComments: Yes
