Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10990 )
Change subject: memrowset: support iteration with is_deleted virtual column ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/10990/10/src/kudu/tablet/memrowset.h File src/kudu/tablet/memrowset.h: http://gerrit.cloudera.org:8080/#/c/10990/10/src/kudu/tablet/memrowset.h@583 PS10, Line 583: // The index of the first IS_DELETED virtual column in the projection schema, > Does this mean multiple IS_DELETED columns are not allowed? Is there a chec I don't think it really matters. We could prevent there from being more than one, but given that clients will be using a special API to add IS_DELETED to the projection, we could prevent the inclusion of a second one in that special API. -- To view, visit http://gerrit.cloudera.org:8080/10990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6b053f5a3696eb9d7c26b8e3d96752f4f87bcd8 Gerrit-Change-Number: 10990 Gerrit-PatchSet: 10 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 06 Aug 2018 19:28:16 +0000 Gerrit-HasComments: Yes
