ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11100 )
Change subject: Implement BloomFilter Predicate in server side. ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/11100/4/src/kudu/common/column_predicate.h File src/kudu/common/column_predicate.h: http://gerrit.cloudera.org:8080/#/c/11100/4/src/kudu/common/column_predicate.h@286 PS4, Line 286: } > Add a space above. Is the comment correct, what's 'nhash'? Done http://gerrit.cloudera.org:8080/#/c/11100/4/src/kudu/common/column_predicate.cc File src/kudu/common/column_predicate.cc: http://gerrit.cloudera.org:8080/#/c/11100/4/src/kudu/common/column_predicate.cc@42 PS4, Line 42: > (meta-comment) If I understand the changes to this file correctly, Range pr True. I think your advice is very reasonable and I change the relevant code. http://gerrit.cloudera.org:8080/#/c/11100/4/src/kudu/common/column_predicate.cc@460 PS4, Line 460: default: { > Simplify with std::copy_if or something equivalent. Done http://gerrit.cloudera.org:8080/#/c/11100/4/src/kudu/common/column_predicate.cc@563 PS4, Line 563: > likewise Done -- To view, visit http://gerrit.cloudera.org:8080/11100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62c2de42667d0255d94e19db773240f7f9ee636c Gerrit-Change-Number: 11100 Gerrit-PatchSet: 5 Gerrit-Owner: ZhangYao <triplesheep0...@gmail.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: ZhangYao <triplesheep0...@gmail.com> Gerrit-Comment-Date: Thu, 16 Aug 2018 09:35:11 +0000 Gerrit-HasComments: Yes
