ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11100 )
Change subject: Implement BloomFilter Predicate in server side. ...................................................................... Patch Set 9: (5 comments) Thanks a lot :) http://gerrit.cloudera.org:8080/#/c/11100/8/src/kudu/common/column_predicate-test.cc File src/kudu/common/column_predicate-test.cc: http://gerrit.cloudera.org:8080/#/c/11100/8/src/kudu/common/column_predicate-test.cc@77 PS8, Line 77: BloomFilterBuilder* bfb2) { > You shouldn't call this more than once per test. So maybe add it to the fix Get your point, I add rand_ as a member of Test and initialize it in constructor so each test case will have different rand seed and in the same test case will use the same seed. http://gerrit.cloudera.org:8080/#/c/11100/8/src/kudu/common/column_predicate-test.cc@1399 PS8, Line 1399: ColumnPredicate::BloomFilterInner bf2(slice2, bfb2.n_hashes(), MURMUR_HASH_2); > Still got some usage of push_back in this test instead of emplace_back. Done http://gerrit.cloudera.org:8080/#/c/11100/6/src/kudu/common/column_predicate.cc File src/kudu/common/column_predicate.cc: http://gerrit.cloudera.org:8080/#/c/11100/6/src/kudu/common/column_predicate.cc@275 PS6, Line 275: } else { > Yes, please do. Done http://gerrit.cloudera.org:8080/#/c/11100/6/src/kudu/common/wire_protocol-test.cc File src/kudu/common/wire_protocol-test.cc: http://gerrit.cloudera.org:8080/#/c/11100/6/src/kudu/common/wire_protocol-test.cc@555 PS6, Line 555: ASSERT_EQ(predicate->predicate_type(), PredicateType::InBloomFilter); > Yeah, decomposing the one for InList would be great too. I decompose the bloomfilter test and use unique_ptr to wrap the BloomFilterBuilder because it doesn't have a default constructor so I have to use it's point format as member variable. http://gerrit.cloudera.org:8080/#/c/11100/8/src/kudu/util/bloom_filter.h File src/kudu/util/bloom_filter.h: http://gerrit.cloudera.org:8080/#/c/11100/8/src/kudu/util/bloom_filter.h@67 PS8, Line 67: case CITY_HASH: > Nit: don't need the comment here; it's obvious from the default value. Done -- To view, visit http://gerrit.cloudera.org:8080/11100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62c2de42667d0255d94e19db773240f7f9ee636c Gerrit-Change-Number: 11100 Gerrit-PatchSet: 9 Gerrit-Owner: ZhangYao <triplesheep0...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: ZhangYao <triplesheep0...@gmail.com> Gerrit-Comment-Date: Wed, 26 Sep 2018 07:18:58 +0000 Gerrit-HasComments: Yes
