Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10983 )
Change subject: KUDU-1291: efficiently support predicates on non-prefix key components ...................................................................... Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/10983/16/src/kudu/tablet/index_skipscan-test.cc File src/kudu/tablet/index_skipscan-test.cc: http://gerrit.cloudera.org:8080/#/c/10983/16/src/kudu/tablet/index_skipscan-test.cc@104 PS16, Line 104: : IndexSkipScanTest() : : KuduTabletTest(CreateSchema(std::get<0>(GetParam()))) { : const auto& param = GetParam(); : schema_type = std::get<0>(param); : FLAGS_enable_skip_scan = std::get<1>(param); : } : : void SetUp() override { : KuduTabletTest::SetUp(); : ASSERT_OK(tablet()->metadata()->CreateRowSet(&rowset_meta_)); : FillTestTablet(); : } : : // Generates and inserts given number of rows using the given PRNG, : // returns # rows generated that match the predicate_val on predicate_col. : int GenerateData(Random random, int num_rows, int predicate_col_id, int64_t predicate_value) { : : LocalTabletWriter writer(tablet().get(), &client_schema_); : KuduPartialRow row(&client_schema_); : : size_t num_key_cols = client_schema_.num_key_columns(); : int num_matching = 0; : : while (num_rows > 0) { : bool predicate_value_matched = false; : for (int col_idx = 0; col_idx < num_key_cols; col_idx++) { : int64_t value = random.Uniform(1000); : CHECK_OK(row.SetInt64(col_idx, value)); : if (col_idx == predicate_col_id && value == predicate_value) { : predicate_value_matched = true; : } : } : > This is no longer used Bah, yes it is. -- To view, visit http://gerrit.cloudera.org:8080/10983 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I230cd5a288e28ace796b352a603e0d1bcc1e4e0f Gerrit-Change-Number: 10983 Gerrit-PatchSet: 19 Gerrit-Owner: Anupama Gupta <anupama.gu...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Anupama Gupta <anupama.gu...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Mon, 20 Aug 2018 00:25:17 +0000 Gerrit-HasComments: Yes
