Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10983 )
Change subject: KUDU-1291: efficiently support predicates on non-prefix key components ...................................................................... Patch Set 20: (1 comment) http://gerrit.cloudera.org:8080/#/c/10983/20/src/kudu/cfile/cfile_reader.cc File src/kudu/cfile/cfile_reader.cc: http://gerrit.cloudera.org:8080/#/c/10983/20/src/kudu/cfile/cfile_reader.cc@777 PS20, Line 777: if (PREDICT_TRUE(validx_iter_ != nullptr)) { : RETURN_NOT_OK(StoreCurrentValue()); : } > To make sure this patch has no side effects when disabled, this should prob Yep, I think that's a good catch. If we want to have a better assurance that the feature is truly isolated, it's better to gate it on something specific for 'skip index scan'. However, I don't think we have that gate readily available in current implementation. -- To view, visit http://gerrit.cloudera.org:8080/10983 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I230cd5a288e28ace796b352a603e0d1bcc1e4e0f Gerrit-Change-Number: 10983 Gerrit-PatchSet: 20 Gerrit-Owner: Anupama Gupta <anupama.gu...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Anupama Gupta <anupama.gu...@cloudera.com> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Mon, 20 Aug 2018 21:38:06 +0000 Gerrit-HasComments: Yes
