Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11303 )
Change subject: error_manager: rename error types ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11303/1/src/kudu/fs/error_manager.h File src/kudu/fs/error_manager.h: http://gerrit.cloudera.org:8080/#/c/11303/1/src/kudu/fs/error_manager.h@20 PS1, Line 20: #include <string> > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/11303/1/src/kudu/fs/error_manager.cc File src/kudu/fs/error_manager.cc: http://gerrit.cloudera.org:8080/#/c/11303/1/src/kudu/fs/error_manager.cc@44 PS1, Line 44: EmplaceOrUpdate(&callbacks_, e, std::move(cb)); > You're going to need to use EmplaceOrUpdate here, or add it to map-util.h i Done -- To view, visit http://gerrit.cloudera.org:8080/11303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I377904ee51bb0f7b0f1104d7a4723f74d52e6e3f Gerrit-Change-Number: 11303 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Sat, 25 Aug 2018 02:43:23 +0000 Gerrit-HasComments: Yes
