Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11303 to look at the new patch set (#3). Change subject: error_manager: rename error types ...................................................................... error_manager: rename error types The previous ErrorHandlerType enum names weren't very descriptive, and reflected the expected error handling (e.g. fail a disk, fail a tablet), rather than the error itself. In preparation of adding a new error ErrorHandlerType for CFile checksum errors, this patch attempts to clarify usage of the FsErrorManager. As I intend on adding another error type, I updated the error manager to use a map to store its error-handling callbacks, and added a map utility function to facilitate this. Change-Id: I377904ee51bb0f7b0f1104d7a4723f74d52e6e3f --- M src/kudu/fs/error_manager-test.cc M src/kudu/fs/error_manager.cc M src/kudu/fs/error_manager.h M src/kudu/fs/file_block_manager.cc M src/kudu/fs/fs_manager.cc M src/kudu/fs/log_block_manager-test.cc M src/kudu/fs/log_block_manager.cc M src/kudu/gutil/map-util.h M src/kudu/tserver/tablet_server.cc 9 files changed, 118 insertions(+), 105 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/11303/3 -- To view, visit http://gerrit.cloudera.org:8080/11303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I377904ee51bb0f7b0f1104d7a4723f74d52e6e3f Gerrit-Change-Number: 11303 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot