Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11342 )
Change subject: build-support: option to retry all failed tests ...................................................................... Patch Set 2: (1 comment) See this logic here for dist-test. We should be sure the retry logic doesn't overlap: https://github.com/apache/kudu/blob/master/build-support/dist_test.py#L391-L393 Also see here in build-and-test.sh: https://github.com/apache/kudu/blob/master/build-support/jenkins/build-and-test.sh#L282 Do we need to make sure KUDU_FLAKY_TEST_ATTEMPTS isn't set to 1 if the flaky list isn't found? http://gerrit.cloudera.org:8080/#/c/11342/2/build-support/run-test.sh File build-support/run-test.sh: http://gerrit.cloudera.org:8080/#/c/11342/2/build-support/run-test.sh@78 PS2, Line 78: echo "Will retry all failed tests" Nit: I suppose "all" doesn't make sense here since this is a single test. -- To view, visit http://gerrit.cloudera.org:8080/11342 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I24aea0b9e7a1c2c66bc5feffcb454ff01cdca6fd Gerrit-Change-Number: 11342 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 28 Aug 2018 04:14:00 +0000 Gerrit-HasComments: Yes
