Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11342 )
Change subject: build-support: option to retry all failed tests ...................................................................... Patch Set 2: > Patch Set 2: > > (1 comment) > > See this logic here for dist-test. We should be sure the retry logic doesn't > overlap: > https://github.com/apache/kudu/blob/master/build-support/dist_test.py#L391-L393 Good catch; we chatted offline and it seems we just need to pass around the right environment variables. > Also see here in build-and-test.sh: > https://github.com/apache/kudu/blob/master/build-support/jenkins/build-and-test.sh#L282 Yeah, that's setting the number of attempts and setting the list. That number and list are both used in run-test.sh via ctest. > Do we need to make sure KUDU_FLAKY_TEST_ATTEMPTS isn't set to 1 if the flaky > list isn't found? I'm don't think that's necessary since the value of KUDU_FLAKY_TEST_ATTEMPTS is independent of the flaky list. If there's no flaky list but we're set to retry via KUDU_FLAKY_TEST_ATTEMPTS, we currently don't retry. That's still the case if KUDU_RETRY_ALL_FAILED_TESTS is 0. -- To view, visit http://gerrit.cloudera.org:8080/11342 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I24aea0b9e7a1c2c66bc5feffcb454ff01cdca6fd Gerrit-Change-Number: 11342 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 28 Aug 2018 05:32:44 +0000 Gerrit-HasComments: No
