Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11398 )
Change subject: HMS integration: set table owner field in HMS table metadata ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/11398/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11398/1//COMMIT_MSG@20 PS1, Line 20: hte the http://gerrit.cloudera.org:8080/#/c/11398/1/src/kudu/hms/hms_catalog-test.cc File src/kudu/hms/hms_catalog-test.cc: PS1: Any tests where owner is omitted? http://gerrit.cloudera.org:8080/#/c/11398/1/src/kudu/hms/hms_catalog.h File src/kudu/hms/hms_catalog.h: http://gerrit.cloudera.org:8080/#/c/11398/1/src/kudu/hms/hms_catalog.h@62 PS1, Line 62: // Creates a new table entry in the HMS. Should mention what happens if 'owner' is omitted. http://gerrit.cloudera.org:8080/#/c/11398/1/src/kudu/integration-tests/master_hms-itest.cc File src/kudu/integration-tests/master_hms-itest.cc: http://gerrit.cloudera.org:8080/#/c/11398/1/src/kudu/integration-tests/master_hms-itest.cc@74 PS1, Line 74: virtual bool EnableKerberos() { Can be private. http://gerrit.cloudera.org:8080/#/c/11398/1/src/kudu/integration-tests/master_hms-itest.cc@637 PS1, Line 637: cluster_->CreateClient(nullptr, &client_); ASSERT_OK -- To view, visit http://gerrit.cloudera.org:8080/11398 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a25aa0bb52bdd28df28a078fe91f55db9e29482 Gerrit-Change-Number: 11398 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 06 Sep 2018 23:58:11 +0000 Gerrit-HasComments: Yes
