Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11398 )
Change subject: HMS integration: set table owner field in HMS table metadata ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11398/2/src/kudu/hms/hms_catalog.h File src/kudu/hms/hms_catalog.h: http://gerrit.cloudera.org:8080/#/c/11398/2/src/kudu/hms/hms_catalog.h@139 PS2, Line 139: // Sets the Kudu-specific fields in the table without overwriting unrelated fields. > Can you please add a comment here that owner information will not be set if Done http://gerrit.cloudera.org:8080/#/c/11398/2/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/11398/2/src/kudu/tools/kudu-tool-test.cc@2311 PS2, Line 2311: CreateLegacyHmsTable > Do you think it makes sense to test legacy HMS table with ownership as well Great point. Added a test case for a legacy table w/o owner, and additional checking that table ownership is preserved. -- To view, visit http://gerrit.cloudera.org:8080/11398 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a25aa0bb52bdd28df28a078fe91f55db9e29482 Gerrit-Change-Number: 11398 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Mon, 10 Sep 2018 19:54:38 +0000 Gerrit-HasComments: Yes
