Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11515 )
Change subject: [DOCS] Added a version notice for changing kudu table names in Impala ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/11515/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11515/1//COMMIT_MSG@9 PS1, Line 9: With IMPALA-5654, users cannot change kudu.table_name in IMPALA. I think this is too generic and incorrect: for external tables, they still can do that even with IMPALA-5654. IMPALA-5654 affects only internal (a.k.a. managed) tables. http://gerrit.cloudera.org:8080/#/c/11515/1/docs/kudu_impala_integration.adoc File docs/kudu_impala_integration.adoc: http://gerrit.cloudera.org:8080/#/c/11515/1/docs/kudu_impala_integration.adoc@687 PS1, Line 687: if the table is an internal table The enclosed section is named 'Rename the underlying Kudu table for an internal table' So, I don't think this extra is needed here. http://gerrit.cloudera.org:8080/#/c/11515/1/docs/kudu_impala_integration.adoc@697 PS1, Line 697: In Impala 2.11 and lower, if another application has renamed a Kudu table under : Impala, it is possible to re-map an external table to point to a different Kudu : table name. I think this became confusing. What's the extra 'In Impala 2.11 and lower ...' is supposed to mean? That it's impossible to re-map an external table to a different Kudu table or that another application is not able to rename a Kudu table under Impala? As I understand, even in Impala 2.12 and newer it's still possible to re-map an external table to point to a different Kudu table name, i.e. IMPALA-5654 is about internal or managed tables only. -- To view, visit http://gerrit.cloudera.org:8080/11515 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If26f103d931dd7ed57b56cf34b0010d14c098928 Gerrit-Change-Number: 11515 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Wed, 26 Sep 2018 00:41:25 +0000 Gerrit-HasComments: Yes
