Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11515 )

Change subject: ][DOCS] Added a version notice for changing managed Kudu table 
names in Impala
......................................................................


Patch Set 2:

(2 comments)

> (4 comments)

Thank you for the fix!  I think it's just a couple of nits to correct and it's 
good to go.

http://gerrit.cloudera.org:8080/#/c/11515/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11515/2//COMMIT_MSG@7
PS2, Line 7: ]
nit: an extra closing brace; please remove it


http://gerrit.cloudera.org:8080/#/c/11515/2//COMMIT_MSG@9
PS2, Line 9: With IMPALA-5654, users cannot change kudu.table_name in IMPALA for
           : managed Kudu tables created in Impala.
It looks like nitpicking, but this sentence contains mention of Impala twice, 
first as 'IMPALA' and then as 'Impala' (I don't count the reference to Impala 
JIRA ticket).

How about:

With IMPALA-5654, users can no longer change kudu.table_name property for 
managed Kudu tables in Impala.



--
To view, visit http://gerrit.cloudera.org:8080/11515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If26f103d931dd7ed57b56cf34b0010d14c098928
Gerrit-Change-Number: 11515
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <arod...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Comment-Date: Wed, 26 Sep 2018 18:58:21 +0000
Gerrit-HasComments: Yes

Reply via email to