Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11772 )
Change subject: Updating web site for Kudu 1.8.0 release ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/11772/4//COMMIT_MSG Commit Message: PS4: Woops, I found some issues in the doxygen-generated docs for Kudu C++ client API. The issue is that non-exported methods are documented and the doc claims they are in the public C++ API for the Kudu client. I'm about to post a patch with corresponding fixes. Attila, will it be possible to re-generate docs from the fixed version instead of the HEAD in branch-1.8.0? Also, I found one spillage of an internal API method into public API: https://gerrit.cloudera.org/#/c/11779/ I don't think that a blocker for 1.8.0 release, but just FYI. -- To view, visit http://gerrit.cloudera.org:8080/11772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: Iafad2ae1cc4ae5700025ea3167d51c6f886a2240 Gerrit-Change-Number: 11772 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (314) Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: helifu <hzhel...@corp.netease.com> Gerrit-Comment-Date: Thu, 25 Oct 2018 01:20:57 +0000 Gerrit-HasComments: Yes
