Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11772 )
Change subject: Updating web site for Kudu 1.8.0 release ...................................................................... Patch Set 4: > Patch Set 4: > > > > Patch Set 4: Code-Review+1 > > > > > > > > Patch Set 4: > > > > > > > > > > (1 comment) > > > > > > > > Go be honest, I'm not sure if it's a good idea to do that. I > > mean > > > > if someone builds the documentation on their own, it's going > > to be > > > > different from what's on the website and it's too late to cut > > a new > > > > RC as I archived 1.8.0 yesterday. > > > > > > > > On the other hand, I can see why it would be good as most devs > > > > won't use their own doxygen build if it's publicly available. > > > > > > > > What does everyone think? I'm -0 on this. > > > > > > > > Anyway, Status ListPartitions() is not part of 1.8.0 and > > backported > > > > a30c921 on top of branch-1.8.x (https://gerrit.cloudera.org/c/11783) > > > > so I can rebuild the docs if needed or at least it can be > > fixed in > > > > 1.8.1. > > > > > > Sorry for the trouble. I don't feel strong about the need to > > rebuild the docs for 1.8.0: if fixing that in 1.8.1 is the easiest > > way to go, that sounds good to me. > > > > I'm not really saying it's the easiest, as rebuilding the docs is > > straight-forward enough, but I feel it's cleaner if the docs are > > the same on the site and in the released sources. > > Right, I agree -- keeping things consistent is a noble goal. So, having > those docs updated in 1.8.1 looks a better deal to me as well. Thanks! I talked with Todd on Slack, he said it should be okay to publish newer docs than in the tarball if it doesn't make the docs inaccurate. I might be overcomplicating, but I was thinking maybe we could have this checked in this way, then rm the cpp-client-api symlink and create an actual directory with the fixed docs. That way the website would show the fixed docs, but the /release/1.8.0/cpp-client-api docs would still be the actual 1.8.0 docs. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/11772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: Iafad2ae1cc4ae5700025ea3167d51c6f886a2240 Gerrit-Change-Number: 11772 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (314) Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: helifu <hzhel...@corp.netease.com> Gerrit-Comment-Date: Thu, 25 Oct 2018 23:43:47 +0000 Gerrit-HasComments: No
