Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12162 )
Change subject: Support CXXFLAGS ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12162/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12162/1//COMMIT_MSG@13 PS1, Line 13: I'm doing this to make it easier to stage a GCC : upgrade in Impala. > I'm curious about this: are you using _GLIBCXX_USE_CXX11_ABI=0 temporarily, Yeah, the problem is that we can build against either the Kudu client from the toolchain or a Kudu client provided along with the other Hadoop components. We'd want to switch to the new ABI, but that requires switching everything at once. We'll still have to do that, but it'll be easier if it's decoupled from the compiler version bump and whatever fallout comes from that. http://gerrit.cloudera.org:8080/#/c/12162/1/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/12162/1/CMakeLists.txt@125 PS1, Line 125: # Start with flags from the standard CXXFLAGS environment variable. : # Additional flags are appended after $CXXFLAGS, so that the Kudu build : # overrides any generic flags. : set(CXX_COMMON_FLAGS "$ENV{CXXFLAGS}") > What if we changed L215-L229 such that CMAKE_CXX_FLAGS is no longer clobber That makes a lot of sense. I did the simplest possible thing in the next PS. As a consequence CXX_COMMON_FLAGS ends up coming before $ENV{CXXFLAGS}. I don't know if the order of those flags really matters but LMK if I should tweak that. -- To view, visit http://gerrit.cloudera.org:8080/12162 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9dcad5ccb4fc4c081d96eaa40957175731c7a9e Gerrit-Change-Number: 12162 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 04 Jan 2019 23:58:30 +0000 Gerrit-HasComments: Yes
