Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12162 to look at the new patch set (#2). Change subject: Support CXXFLAGS ...................................................................... Support CXXFLAGS I ran into a case when building Kudu in native-toolchain where I want to build Kudu with flags matching those used by other libraries. Specifically, "-D_GLIBCXX_USE_CXX11_ABI=0" is needed to allow linking with other libraries built with that flag. I'm doing this to make it easier to stage a GCC upgrade in Impala. By default CMake puts CXXFLAGS into CMAKE_CXX_FLAGS but this is then clobbered by Kudu's CMake script. See https://cmake.org/cmake/help/latest/envvar/CXXFLAGS.html The fix is to append to CMAKE_CXX_FLAGS instead of overwriting it. Change-Id: Id9dcad5ccb4fc4c081d96eaa40957175731c7a9e --- M CMakeLists.txt 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/12162/2 -- To view, visit http://gerrit.cloudera.org:8080/12162 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id9dcad5ccb4fc4c081d96eaa40957175731c7a9e Gerrit-Change-Number: 12162 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120)