Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12184 )
Change subject: rpc: add TCP socket statistics to /rpcz ...................................................................... Patch Set 1: (4 comments) LGTM and it compiles and runs on macOS. Just some nits so far. http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/connection.cc File src/kudu/rpc/connection.cc: http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/connection.cc@959 PS1, Line 959: nit: are these tabs? If yes, replace with spaces. http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/connection.cc@968 PS1, Line 968: nit: ditto http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/connection.cc@970 PS1, Line 970: ditto http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/reactor.h File src/kudu/rpc/reactor.h: http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/reactor.h@152 PS1, Line 152: DumpRunningRpcs > should probably rename this and related calls yep, that would be nice to match the name of those methods wrt new names for corresponding PB structures. -- To view, visit http://gerrit.cloudera.org:8080/12184 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I552c9dd80c0730ccd6bf7b13bb63761744a854c2 Gerrit-Change-Number: 12184 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 09 Jan 2019 20:48:38 +0000 Gerrit-HasComments: Yes
