Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12184 )
Change subject: rpc: add TCP socket statistics to /rpcz ...................................................................... Patch Set 2: (1 comment) Looks reasonable to me! http://gerrit.cloudera.org:8080/#/c/12184/2/src/kudu/rpc/rpc_introspection.proto File src/kudu/rpc/rpc_introspection.proto: http://gerrit.cloudera.org:8080/#/c/12184/2/src/kudu/rpc/rpc_introspection.proto@53 PS2, Line 53: message SocketStatsPB { Do these need more documentation, or a pointer to the relevant header file? -- To view, visit http://gerrit.cloudera.org:8080/12184 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I552c9dd80c0730ccd6bf7b13bb63761744a854c2 Gerrit-Change-Number: 12184 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Mon, 28 Jan 2019 21:59:22 +0000 Gerrit-HasComments: Yes
