Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12219 )
Change subject: [docs] Add docs for rack/location-awareness ...................................................................... Patch Set 1: (12 comments) http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc File docs/administration.adoc: http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@208 PS1, Line 208: Kudu supports a rack awareness feature from version 1.9. Kudu's ordinary > Nit: maybe "As of version 1.9, Kudu supports a rack awareness feature"? Done http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@209 PS1, Line 209: protect > Nit: maybe 'ensure' is more precise? Done http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@213 PS1, Line 213: sorts > Nit: 'kinds' is more precise (avoids ambiguity with the verb form of 'sorts Done http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@252 PS1, Line 252: can reestablish the placement policy if it is : violated and if it is possible to move replicas of the tablets which violate the : placement policy in such a way that the placement policy will no longer be : violated after the replica moves are complete > Nit: This seems unnecessarily verbose. Maybe "can restore the placement pol Done http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@256 PS1, Line 256: conform > Nit: use the same verb here as in the previous sentence (either reestablish One cannot "reestablish" or "restore" the placement policy on a cluster that was just upgraded to use location awareness and that may never have conformed to the policy before. Howabout "can also be used to establish the placement policy on a cluster if it has just been..."? Sounds a little worse than using "conform" to me but I'm ok with either. http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@258 PS1, Line 258: fixed > Nit: moved Tablets aren't moved; replicas are. Tablets are fixed (re the placement policy) by moving replicas. Howabout "and existing replicas need to be moved to comply with the placement policy"? http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@1345 PS1, Line 1345: conform > Nit: reestablish (or restore, or whatever. See above) Same idea as before. I tried using "establish" instead. LMKWYT. http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@1347 PS1, Line 1347: in a : situation where it was not possible to place a replica in accord with the : policy. > Nit: I think you can drop this section, unnecessarily verbose. Done http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@1351 PS1, Line 1351: re-establishes > re-establish Done http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@1354 PS1, Line 1354: between locations in an attempt to spread tablet replicas among location > locations Done http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@1358 PS1, Line 1358: balances > Is there a significance I'm not seeing for the use of "balances" here vs. " Done http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@1359 PS1, Line 1359: such > Nit: 'the' instead Done -- To view, visit http://gerrit.cloudera.org:8080/12219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I505b7fd545a4253170a5b7cac63c33e7d9669490 Gerrit-Change-Number: 12219 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Fri, 11 Jan 2019 20:32:01 +0000 Gerrit-HasComments: Yes
