Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12219 )
Change subject: [docs] Add docs for rack/location-awareness ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc File docs/administration.adoc: http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@256 PS1, Line 256: conform > I like your new approach more actually. I don't think you can "conform" som You can! Conform is a transitive verb :themoreyouknow:. See https://www.merriam-webster.com/dictionary/conform. http://gerrit.cloudera.org:8080/#/c/12219/2/docs/administration.adoc File docs/administration.adoc: http://gerrit.cloudera.org:8080/#/c/12219/2/docs/administration.adoc@218 PS2, Line 218: and where : each `/`-separated component > nit: reads a bit funny imo, maybe "a `/`-separated string ... in which each "in which" reads funny to me, so I'm going to leave it my way. http://gerrit.cloudera.org:8080/#/c/12219/2/docs/administration.adoc@239 PS2, Line 239: `/L0`, `/L1`, `/L1`, `/L2` > May want to specify how the policy will handle multi-component locations. E Added a bit that we don't use the hierarchical structure though we might in the future. http://gerrit.cloudera.org:8080/#/c/12219/2/docs/administration.adoc@1348 PS2, Line 1348: o place a replica in accord wi > What does this mean? Ask Adar :) http://gerrit.cloudera.org:8080/#/c/12219/2/docs/administration.adoc@1354 PS2, Line 1354: re > nit: flag Done -- To view, visit http://gerrit.cloudera.org:8080/12219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I505b7fd545a4253170a5b7cac63c33e7d9669490 Gerrit-Change-Number: 12219 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Fri, 11 Jan 2019 23:13:11 +0000 Gerrit-HasComments: Yes
