Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12170 )
Change subject: client: avoid accessing state after scheduling retry ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/12170/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12170/3//COMMIT_MSG@45 PS3, Line 45: I : tested this by looping a test[1] that repeatedly called : Client::IsCreateTableInProgress() on a multi-master cluster configured : to have election storms, and observing 5/1000 that yielded TSAN errors : around the logging calls in RetryOrReconnectIfNecessary. > And presumably when looped with the fix there were no failures? Yes http://gerrit.cloudera.org:8080/#/c/12170/3/src/kudu/client/master_proxy_rpc.cc File src/kudu/client/master_proxy_rpc.cc: http://gerrit.cloudera.org:8080/#/c/12170/3/src/kudu/client/master_proxy_rpc.cc@184 PS3, Line 184: Status* status) { > Why drop the scoped cleanup though? Wasn't it a reasonable way to avoid cod Done -- To view, visit http://gerrit.cloudera.org:8080/12170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8cefd9613018247a1a25d17adedc021e8be166f6 Gerrit-Change-Number: 12170 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Sat, 12 Jan 2019 02:48:12 +0000 Gerrit-HasComments: Yes
