Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12170 )
Change subject: client: avoid accessing state after scheduling retry ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12170/4/src/kudu/client/master_proxy_rpc.cc File src/kudu/client/master_proxy_rpc.cc: http://gerrit.cloudera.org:8080/#/c/12170/4/src/kudu/client/master_proxy_rpc.cc@188 PS4, Line 188: we pass in a copy of the string I'm not sure I understand: if that's about the 'retry_warning' string, then why that be a copy when everything is passed by reference as '[&]' notation suggests? So, the idea is to use the 'retry_warning' string because it will be destroyed last since it's the first object on the stack of this method? If so, then I don't quite understand why Substitute() would not work (as of original version). That expression uses members (i.e. aggregated fields) of this class like 'client_' and 'rpc_name_', and those are supposed to be alive when this method exits. Unless the method or the functions calls itself do 'delete this' or other funny stuff happens in the middle. Might something else be at play here? -- To view, visit http://gerrit.cloudera.org:8080/12170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8cefd9613018247a1a25d17adedc021e8be166f6 Gerrit-Change-Number: 12170 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Sat, 12 Jan 2019 07:00:24 +0000 Gerrit-HasComments: Yes
