Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12173 )
Change subject: [docker] Add an initial docker build ...................................................................... Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/12173/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12173/2//COMMIT_MSG@20 PS2, Line 20: muti multi http://gerrit.cloudera.org:8080/#/c/12173/2/docker/Dockerfile File docker/Dockerfile: http://gerrit.cloudera.org:8080/#/c/12173/2/docker/Dockerfile@71 PS2, Line 71: # TODO: Remove build dir too? In theory you could remove thirdparty/build too, except that the clang-toolchain symlink points to llvm-6.0.0 within it. Off the top of my head I can't remember why that's the case (i.e. why it doesn't point to somewhere in thirdparty/installed). http://gerrit.cloudera.org:8080/#/c/12173/2/docker/Dockerfile@110 PS2, Line 110: COPY ./docs/support docs/support Can we skip this? Not seeing where we build docs below. http://gerrit.cloudera.org:8080/#/c/12173/2/docker/Dockerfile-files File docker/Dockerfile-files: http://gerrit.cloudera.org:8080/#/c/12173/2/docker/Dockerfile-files@18 PS2, Line 18: # This docker file is a minimal build usefull for debugging useful http://gerrit.cloudera.org:8080/#/c/12173/2/docker/kudu-entrypoint.sh File docker/kudu-entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/12173/2/docker/kudu-entrypoint.sh@49 PS2, Line 49: KUDU_OPTS="$KUDU_FLAGS \ Is the idea that KUDU_FLAGS can be set by users to do more configuration? Maybe doc that at the top of the file? http://gerrit.cloudera.org:8080/#/c/12173/2/docker/kudu-entrypoint.sh@52 PS2, Line 52: --fs_data_dirs=/var/lib/kudu/master \ You can omit this if the intent is to use the same value as --fs_wal_dir. Below too. http://gerrit.cloudera.org:8080/#/c/12173/2/thirdparty/build-thirdparty.sh File thirdparty/build-thirdparty.sh: http://gerrit.cloudera.org:8080/#/c/12173/2/thirdparty/build-thirdparty.sh@248 PS2, Line 248: # Install Hadoop, Hive, and Sentry by copying their source directories into $PREFIX/opt. : # Copying allows the source directory to be removed once thirdparty is built. How much additional disk space will this consume? Also, will the migration be smooth for existing thirdparty trees where these are symlinks? Looking at the build results for this patch, looks like the migration doesn't work at all. Maybe we need to rm -rf the existing symlinks first? I wonder if we should use rsync to manage this instead, as it'll do a better job of synchronizing the source and destination. -- To view, visit http://gerrit.cloudera.org:8080/12173 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95497b39e47f07301be75cbadd814656c7e2ea42 Gerrit-Change-Number: 12173 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 22 Jan 2019 21:44:59 +0000 Gerrit-HasComments: Yes
