Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12173 )

Change subject: [docker] Add an initial docker build
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12173/2/thirdparty/build-thirdparty.sh
File thirdparty/build-thirdparty.sh:

http://gerrit.cloudera.org:8080/#/c/12173/2/thirdparty/build-thirdparty.sh@248
PS2, Line 248: # Install Hadoop, Hive, and Sentry by copying their source 
directories into $PREFIX/opt.
             : # Copying allows the source directory to be removed once 
thirdparty is built.
> This will add ~400MB of space. But it allows me to save almost 2 GiB in the
Hmm, that's a fair amount of space relative to the size of the thirdparty 
install tree right now: counting both common and uninstrumented, we're sitting 
at 1.8 GB. Not to mention it appears to have broken dist-test in some way.

Can we keep the symlinks but special-case the docker build to remove them and 
copy the files in?



--
To view, visit http://gerrit.cloudera.org:8080/12173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95497b39e47f07301be75cbadd814656c7e2ea42
Gerrit-Change-Number: 12173
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 23 Jan 2019 05:34:09 +0000
Gerrit-HasComments: Yes

Reply via email to