Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12689 )
Change subject: [java] Add private diff scan support ...................................................................... Patch Set 8: (10 comments) http://gerrit.cloudera.org:8080/#/c/12689/8/java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java File java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java: http://gerrit.cloudera.org:8080/#/c/12689/8/java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java@373 PS8, Line 373: * when serializing the Sentence trails off. http://gerrit.cloudera.org:8080/#/c/12689/8/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java File java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java: http://gerrit.cloudera.org:8080/#/c/12689/8/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@a251 PS8, Line 251: Is there any concern that someone was previously abusing getLong() by using it on a STRING type? And now they won't be allowed to do that? http://gerrit.cloudera.org:8080/#/c/12689/8/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@253 PS8, Line 253: return Bytes.getLong(this.rowData.getRawArray(), : this.rowData.getRawOffset() + : getCurrentRowDataOffsetForColumn(columnIndex)); This can chain to getIndirectDataOffset. http://gerrit.cloudera.org:8080/#/c/12689/8/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@370 PS8, Line 370: long micros = Bytes.getLong(this.rowData.getRawArray(), : this.rowData.getRawOffset() + : getCurrentRowDataOffsetForColumn(columnIndex)); As can this. http://gerrit.cloudera.org:8080/#/c/12689/8/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@497 PS8, Line 497: * @return the Didn't fill this out? http://gerrit.cloudera.org:8080/#/c/12689/8/java/kudu-client/src/main/java/org/apache/kudu/util/TimestampUtil.java File java/kudu-client/src/main/java/org/apache/kudu/util/TimestampUtil.java: http://gerrit.cloudera.org:8080/#/c/12689/8/java/kudu-client/src/main/java/org/apache/kudu/util/TimestampUtil.java@97 PS8, Line 97: public static String timestampToString(long micros) { Kinda confusing that this method claims to convert a "timestamp" into a string when in fact it operates on a micros integer value. I mean, It'd be OK if we didn't have the other methods above for whom "timestamp" means java.sql.Timestamp. http://gerrit.cloudera.org:8080/#/c/12689/6/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/12689/6/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@190 PS6, Line 190: LOG.info("Before: {}", before); > Are you sure that startHT will have a value >= the HTs associated with the Any update here? I think you could use KuduClient.getLastObservedTimestamp() for the lower bound, as it'll represent the latest timestamp used by the writes in applyOperations. Maybe need to +1 it though. http://gerrit.cloudera.org:8080/#/c/12689/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/12689/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@266 PS8, Line 266: it's Nit: its http://gerrit.cloudera.org:8080/#/c/12689/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@269 PS8, Line 269: Map<Integer, ChangeType> results = new HashMap<>(); Worth noting that, except for logging, the test currently doesn't use these results at all, so unless you intend to do something with them in a subsequent patch, you could save a few LOC and not generate them. http://gerrit.cloudera.org:8080/#/c/12689/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@336 PS8, Line 336: operations operation -- To view, visit http://gerrit.cloudera.org:8080/12689 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51b01ae76cd22407df9097b56629ac7262ec2964 Gerrit-Change-Number: 12689 Gerrit-PatchSet: 8 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Mon, 18 Mar 2019 17:35:58 +0000 Gerrit-HasComments: Yes
