Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12689 )
Change subject: [java] Add private diff scan support ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/12689/8/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java File java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java: http://gerrit.cloudera.org:8080/#/c/12689/8/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@253 PS8, Line 253: return Bytes.getLong(this.rowData.getRawArray(), : this.rowData.getRawOffset() + : getCurrentRowDataOffsetForColumn(columnIndex)); > Even though the "code" is the same I don't call that function since this is Why does it matter? If the code is the same, the result will be the same and we'll reduce LOC by a bit, and I'd add that this array offsetting is not trivial code either. If you think it'll look confusing, a one-line comment should clarify while still allowing us to reuse the code. http://gerrit.cloudera.org:8080/#/c/12689/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/12689/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@269 PS8, Line 269: Map<Integer, ChangeType> results = new HashMap<>(); > The return value is stored in the `mutations` variable and used to lookup a Ah yes, of the three calls, one does use the return results. -- To view, visit http://gerrit.cloudera.org:8080/12689 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51b01ae76cd22407df9097b56629ac7262ec2964 Gerrit-Change-Number: 12689 Gerrit-PatchSet: 9 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Mon, 18 Mar 2019 18:03:17 +0000 Gerrit-HasComments: Yes
