Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12815 )
Change subject: tserver: sanitize write op types ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12815/2/src/kudu/common/row_operations-test.cc File src/kudu/common/row_operations-test.cc: http://gerrit.cloudera.org:8080/#/c/12815/2/src/kudu/common/row_operations-test.cc@22 PS2, Line 22: #include <ostream> > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/12815/2/src/kudu/common/row_operations.cc File src/kudu/common/row_operations.cc: http://gerrit.cloudera.org:8080/#/c/12815/2/src/kudu/common/row_operations.cc@562 PS2, Line 562: // TODO: there's a bug here, in that if a client passes some column > warning: missing username/bug in TODO [google-readability-todo] Done -- To view, visit http://gerrit.cloudera.org:8080/12815 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib27c335e6a68336b88f75eb8fa2c45c6e18403d5 Gerrit-Change-Number: 12815 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Sat, 23 Mar 2019 04:48:18 +0000 Gerrit-HasComments: Yes
