Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12815 )
Change subject: tserver: sanitize write op types ...................................................................... tserver: sanitize write op types We previously wouldn't make sure that Write requests actually contained write operations (i.e. INSERT, UPDATE, UPSERT, DELETE). The result is that a malicious user could send a bad write request to crash a tablet server. This patch addresses this by adding different decoder modes (e.g. for writes, for split rows), and using the appropriate decoding mode for writes. Change-Id: Ib27c335e6a68336b88f75eb8fa2c45c6e18403d5 Reviewed-on: http://gerrit.cloudera.org:8080/12815 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <[email protected]> --- M src/kudu/common/row_operations-test.cc M src/kudu/common/row_operations.cc M src/kudu/common/row_operations.h M src/kudu/master/catalog_manager.cc M src/kudu/tablet/tablet.cc M src/kudu/tools/tool_action_common.cc M src/kudu/tserver/tablet_server-test.cc 7 files changed, 138 insertions(+), 43 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/12815 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib27c335e6a68336b88f75eb8fa2c45c6e18403d5 Gerrit-Change-Number: 12815 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]>
