Hello Mike Percy, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12946
to review the following change.
Change subject: generic_iterators: pass rowset bounds into grouping iterators
......................................................................
generic_iterators: pass rowset bounds into grouping iterators
The rowset bounds will be used to reduce MergeIterator memory consumption by
restricting the "eager RowBlock fetching" behavior at Init time to only
those sub-iterators whose rowsets could conceivably participate in the
beginning of the merge.
Normally the rowset bounds are encoded, but they need to be decoded upon
arrival because they're going to be compared against decoded rows returned
from sub-iterators, and it's far more efficient to decode the bounds once
when initializing the MergeIterator than to encode the rows repeatedly
during the merge.
Change-Id: Id1aebd84507f87c869d781e117225c37c8f15969
---
M src/kudu/common/generic_iterators-test.cc
M src/kudu/common/generic_iterators.cc
M src/kudu/common/generic_iterators.h
M src/kudu/tablet/rowset.cc
M src/kudu/tablet/rowset.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
7 files changed, 174 insertions(+), 84 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/12946/1
--
To view, visit http://gerrit.cloudera.org:8080/12946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1aebd84507f87c869d781e117225c37c8f15969
Gerrit-Change-Number: 12946
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
