Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12946 )
Change subject: generic_iterators: pass rowset bounds into grouping iterators ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/12946/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12946/6//COMMIT_MSG@14 PS6, Line 14: Normally the rowset bounds are encoded, but they need to be decoded upon I'm confused about this part. Is this comment still relevant to this patch, where we are passing the encoded bounds into the IterWithBounds? -- To view, visit http://gerrit.cloudera.org:8080/12946 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1aebd84507f87c869d781e117225c37c8f15969 Gerrit-Change-Number: 12946 Gerrit-PatchSet: 6 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Sat, 13 Apr 2019 00:49:15 +0000 Gerrit-HasComments: Yes
