Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12951 )
Change subject: [HaClient] introduce client metrics ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/12951/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12951/3//COMMIT_MSG@9 PS3, Line 9: Introduced metrics for HA Sentry client in SentryAuthzProvider. Are you going to roll out something similar for the HMS client? It'd certainly benefit from the increased observability. http://gerrit.cloudera.org:8080/#/c/12951/3/src/kudu/master/sentry_authz_provider-test.cc File src/kudu/master/sentry_authz_provider-test.cc: http://gerrit.cloudera.org:8080/#/c/12951/3/src/kudu/master/sentry_authz_provider-test.cc@749 PS3, Line 749: ASSERT_EQ(0, GetTasksFailedNonFatal()); Can we test that this increases? http://gerrit.cloudera.org:8080/#/c/12951/3/src/kudu/thrift/client.h File src/kudu/thrift/client.h: http://gerrit.cloudera.org:8080/#/c/12951/3/src/kudu/thrift/client.h@287 PS3, Line 287: if (PREDICT_TRUE(metrics_)) { : metrics_->tasks_failed_fatal->Increment(); : } Why is this conditioned on attempt == 0? -- To view, visit http://gerrit.cloudera.org:8080/12951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I86e12ee6ee34f39c11f18b21e846cc5a1dee6b6f Gerrit-Change-Number: 12951 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 08 Apr 2019 05:02:31 +0000 Gerrit-HasComments: Yes
