Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12951 )
Change subject: [HaClient] introduce client metrics ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/12951/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12951/3//COMMIT_MSG@9 PS3, Line 9: Introduced metrics for HA Sentry client in SentryAuthzProvider. > Are you going to roll out something similar for the HMS client? It'd certai Yep, I think it's better to do that in a separate patch. I opened the following JIRA to track that: https://issues.apache.org/jira/browse/KUDU-2766 http://gerrit.cloudera.org:8080/#/c/12951/3/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/12951/3/src/kudu/master/catalog_manager.cc@4680 PS3, Line 4680: optional<const string&> user) { > warning: the parameter 'user' is copied for each invocation but only used a I'm going to ignore this in the scope of this changelist. http://gerrit.cloudera.org:8080/#/c/12951/3/src/kudu/master/sentry_authz_provider-test.cc File src/kudu/master/sentry_authz_provider-test.cc: http://gerrit.cloudera.org:8080/#/c/12951/3/src/kudu/master/sentry_authz_provider-test.cc@749 PS3, Line 749: ASSERT_EQ(0, GetTasksFailedNonFatal()); > Can we test that this increases? Good idea, however I could not find a way to get non-fatal error code from ListPrivilegesByUser() from Sentry. http://gerrit.cloudera.org:8080/#/c/12951/3/src/kudu/thrift/client.h File src/kudu/thrift/client.h: http://gerrit.cloudera.org:8080/#/c/12951/3/src/kudu/thrift/client.h@287 PS3, Line 287: if (PREDICT_TRUE(metrics_)) { : metrics_->tasks_failed_fatal->Increment(); : } > Why is this conditioned on attempt == 0? Because that's the first time a failure is noticed, and later failures will happen because of retries. I think the tasks_failed_fatal should not count duplicates/retries for clarity; also, tasks_failed_nonfatal doesn't count retries either. -- To view, visit http://gerrit.cloudera.org:8080/12951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I86e12ee6ee34f39c11f18b21e846cc5a1dee6b6f Gerrit-Change-Number: 12951 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 09 Apr 2019 02:13:46 +0000 Gerrit-HasComments: Yes
