Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13069 )
Change subject: [authz] new SentryAuthzProvider's caching strategy ...................................................................... Patch Set 9: Code-Review+2 (1 comment) LGTM, probably good to get a signoff from Hao re the tests she requested. http://gerrit.cloudera.org:8080/#/c/13069/7/src/kudu/master/sentry_privileges_fetcher.cc File src/kudu/master/sentry_privileges_fetcher.cc: http://gerrit.cloudera.org:8080/#/c/13069/7/src/kudu/master/sentry_privileges_fetcher.cc@538 PS7, Line 538: FATAL) << Substitute( : "requesting privileges of the SERVER scope from Sentry " > From the other side, if thinking about running this code in kudu-master pro Ah, great point! SGTM. -- To view, visit http://gerrit.cloudera.org:8080/13069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id96181345e357a104e28314d8d8d88633dcf9608 Gerrit-Change-Number: 13069 Gerrit-PatchSet: 9 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Comment-Date: Thu, 25 Apr 2019 00:45:05 +0000 Gerrit-HasComments: Yes
