Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13069 )
Change subject: [authz] new SentryAuthzProvider's caching strategy ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/13069/9/src/kudu/master/sentry_authz_provider-test.cc File src/kudu/master/sentry_authz_provider-test.cc: http://gerrit.cloudera.org:8080/#/c/13069/9/src/kudu/master/sentry_authz_provider-test.cc@855 PS9, Line 855: ASSERT_EQ(1, GetTasksSuccessful()); > Is it possible to check the size of the cache entries? If not, just ignore It's possible to check the contents of each entry of the cache if you know their keys. And it's possible to check the overall size of the cache -- there is a cache's metric for that. I guess you'd like to make sure the cache entry for the 'db' authorizable doesn't contain information on 't0' and 't1' after call to AuthorizeCreateTable("db.table")? Yep, we can do that. Let me do that in a separate follow-up patch: this patch has already been around for some time, so more conflicts to resolve with other patches around. -- To view, visit http://gerrit.cloudera.org:8080/13069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id96181345e357a104e28314d8d8d88633dcf9608 Gerrit-Change-Number: 13069 Gerrit-PatchSet: 9 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Comment-Date: Thu, 25 Apr 2019 16:31:19 +0000 Gerrit-HasComments: Yes
