Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13124 )
Change subject: hms: remove experimental tag from hms flags ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13124/1/src/kudu/hms/hms_catalog.cc File src/kudu/hms/hms_catalog.cc: http://gerrit.cloudera.org:8080/#/c/13124/1/src/kudu/hms/hms_catalog.cc@a83 PS1, Line 83: > Adar's suggestion sounds reasonable to me as well. BTW, maybe tag the rest Done. I don't think I'll tag these first three "advanced" though. Usage of the HMS integration will require the user to think about those flags, which kind of goes against the "advanced" description: they're also likely to be used only rarely and should be relegated to more detailed sections of documentation. I.e. I don't think we expect them to be used rarely, whereas we probably don't expect users to have to tune the HMS thrift client configurations very often. -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Apr 2019 06:51:42 +0000 Gerrit-HasComments: Yes
