Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13124 )
Change subject: hms: remove experimental tag from hms flags ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/13124/2/src/kudu/hms/hms_catalog.cc File src/kudu/hms/hms_catalog.cc: http://gerrit.cloudera.org:8080/#/c/13124/2/src/kudu/hms/hms_catalog.cc@71 PS2, Line 71: DEFINE_string(hive_metastore_kerberos_principal, "hive", : "The service principal of the Hive Metastore server. Must match " : "the primary (user) portion of hive.metastore.kerberos.principal option " : "in the Hive Metastore configuration."); Of the first three, should this be 'advanced'? Or do you also expect it to be used semi-frequently? -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Apr 2019 18:33:14 +0000 Gerrit-HasComments: Yes