Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13139 )
Change subject: [tools] command to reset authz cache in kudu CLI ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/13139/1/src/kudu/tools/CMakeLists.txt File src/kudu/tools/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/13139/1/src/kudu/tools/CMakeLists.txt@45 PS1, Line 45: tool_action.cc : table_scanner.cc Revert alphabetical order? http://gerrit.cloudera.org:8080/#/c/13139/1/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/13139/1/src/kudu/tools/tool_action_master.cc@197 PS1, Line 197: t pri nit: the http://gerrit.cloudera.org:8080/#/c/13139/1/src/kudu/tools/tool_action_master.cc@202 PS1, Line 202: Operate on authz cache nit: how about "Operate on the authz cache of a Kudu Master" http://gerrit.cloudera.org:8080/#/c/13139/1/src/kudu/tools/tool_action_master.cc@195 PS1, Line 195: unique_ptr<Action> action_reset = : ActionBuilder("reset", &ResetAuthzCache) : .Description("Reset privileges cache") : .AddRequiredParameter({ kMasterAddressArg, kMasterAddressDesc }) : .Build(); : : unique_ptr<Mode> mode_authz_cache = ModeBuilder("authz_cache") : .Description("Operate on authz cache") : .AddAction(std::move(action_reset)) : .Build(); : builder.AddMode(std::move(mode_authz_cache)); Why bother separating this out? My guess is this is in preparation for further tooling? Perhaps a `kudu master authz_cache list` tool or somesuch? -- To view, visit http://gerrit.cloudera.org:8080/13139 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If49f3ebdea22ea0df3aaec313b4db949dc834943 Gerrit-Change-Number: 13139 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 27 Apr 2019 04:58:54 +0000 Gerrit-HasComments: Yes
