Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13139 )
Change subject: [tools] command to reset authz cache in kudu CLI ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/13139/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13139/1//COMMIT_MSG@12 PS1, Line 12: kudu master authz_cache reset <master_address> But don't we want this to be a cluster command that invalidates the authz caches on _all_ masters? Otherwise we might have follower masters with stale privileges. An alternative would be to invalidate the cache when a master becomes leader. http://gerrit.cloudera.org:8080/#/c/13139/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/13139/1/src/kudu/tools/kudu-tool-test.cc@1014 PS1, Line 1014: "authz_cache.*Operate on the authz cache of a Kudu Master", Should also add a test for the help output of the authz cache mode. -- To view, visit http://gerrit.cloudera.org:8080/13139 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If49f3ebdea22ea0df3aaec313b4db949dc834943 Gerrit-Change-Number: 13139 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 29 Apr 2019 22:16:41 +0000 Gerrit-HasComments: Yes